fix(flags): Enqueue follow up requests without dropping #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +160 B (0%) Total Size: 685 kB
ℹ️ View Unchanged
|
benjackwhite
approved these changes
Sep 14, 2023
|
Ok, figured out what the resetQueue was for: it's for any Phew, this is very spider webby. But I added a few new explicit tests for this, to make future refactors easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
My previous PR delayed reloading to the end of the decide request: #791 , and for some reason I copied the wrong queue deletion behaviour instead of fixing it right in that PR 🤦 .
If
posthog.identify()was called while we were requesting flags, we should queue this up and not drop it, as otherwise flags will stick around for the anon user rather than the identified one.Fixes this behaviour,
and removes the now-unusedresetRequestQueuefunction...
Checklist